Code review¶

The code-reviewing process is an essential part of software development that ensures code quality and consistency.

Following practices has been used PSS®X during the code-reviewing process:

1. Assign clear roles and responsibilities¶

Roles and responsibilities of the reviewers such as the primary reviewer, secondary reviewer, and approver are clearly defined.

2. Only block a MR if it needs approver approval¶

Request changes sounds harmless. But there’s a reason it’s written in RED.

3. Review early and often¶

Establish early and frequent code reviews to catch problems early in the development cycle.

4. Show ! Don't tell¶

When it could have just written a code snippet DO NOT waste your time to describing changes.

5. Give critical feedback in person.¶

Just DO NOT write a 5 paragraph essay and bait people ego's to get involved.

6. Review the big picture first.¶

Review the big picture first. API changes, schema changes. Everything high level. Those new unit tests might get re-written anyway.